apache / apache/dubbo

Can we move the SPI definition in config-center-api to dubbo-common?

Open
#4,054 2 comments 0 reactions 0 assignees View on GitHub
type/proposal
Dominant language
Java
Stars
41.6k
Forks
26.4k
Avg merge
15h 13m
Merged PRs (30d)
4

Description

I am thinking of moving the SPI definition in `config-center-api` to `dubbo-common`. The `DynamicConfiguration`, which works as a basis for almost features that need configuration inputs, can help us to get properties from external config center. Putting it in the code base module would be more convenient for other modules that rely on it to use, and also helps to simplify the dependency structure.

![image](https://user-images.githubusercontent.com/18097545/57685179-eb219100-7669-11e9-99e0-6afc54d833b3.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.