apache / apache/dubbo

Adjusting cluster invoker checks

Open
#12,138 0 comments 0 reactions 0 assignees View on GitHub
type/proposal
Dominant language
Java
Stars
41.6k
Forks
26.4k
Avg merge
15h 13m
Merged PRs (30d)
4

Description

The current check on cluster invoker is placed in the corresponding implementation class, and almost all implementation classes of AbstractClusterInvoker will call this method.
for example:
![image](https://user-images.githubusercontent.com/44110731/233130782-f2f3383e-af60-4a96-9017-c697ffbdc74b.png)

However, when the cluster invokers are empty, the subsequent load balancing process is useless.
![image](https://user-images.githubusercontent.com/44110731/233131589-4034fafa-a06c-4455-bc09-60a8d9ffc8d1.png)

So I think the check for clustered invokers should be adjusted。
![1681919440814](https://user-images.githubusercontent.com/44110731/233132405-3201c351-a53f-41a9-86bd-91b8d2e1680e.png)

Contributor guide

Open the contributing guide

Research direction

Start by locating AbstractClusterInvoker and the implementation classes that call its cluster-invoker check. Compare the current check with the subsequent load-balancing path shown in the issue. Done means empty cluster invokers are detected before unnecessary load balancing, with the surrounding behavior preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
distributed-systems
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.