ApplicationDeployer and ModuleDeployer interfaces have some duplicated methods comparing with Deployer . Can we delete it?
- Dominant language
- Java
- Stars
- 41.6k
- Forks
- 26.4k
- Avg merge
- 15h 13m
- Merged PRs (30d)
- 4
Description
ApplicationDeployer and ModuleDeployer interfaces have some duplicated methods comparing with Deployer . Can we delete it?
```java
/**
* Initialize the component
*/
void initialize() throws IllegalStateException;
/**
* Starts the component.
* @return
*/
Future start() throws IllegalStateException;
/**
* Stops the component.
*/
void stop() throws IllegalStateException;
```
These three methods both exists in `ApplicationDeployer`,`ModuleDeployer` and `Deployer` . Can we delete them from `ApplicationDeployer` and `ModuleDeployer` ?
BTW , some methods in `ApplicationDeployer` and `ModuleDeployer` are duplicated. Can we pull them up to `Deployer` ?
If there is no other issue, I will commit a pr to fix them.
Contributor guide
Research direction
Start by reading the ApplicationDeployer, ModuleDeployer, and Deployer interfaces, comparing initialize, start, stop, and the other duplicated methods named in the issue. Then inspect their implementors and usages to identify compatibility impacts. Done means duplication is removed or pulled up without breaking the deployer API or its consumers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100