apache / apache/druid

ensure chill URI escaping is done in all the places

Open
#8,941 0 comments 0 reactions 0 assignees View on GitHub
Bug Refactoring
Dominant language
Java
Stars
14.1k
Forks
3.8k
Avg merge
2d 58m
Merged PRs (30d)
233

Description

### Description
Related in spirit to #6761, except with cloud object paths, based on a couple of discussion threads in #8903:
https://github.com/apache/incubator-druid/pull/8903#discussion_r348869424
https://github.com/apache/incubator-druid/pull/8903#discussion_r349756060

I believe I have fixed up all of the S3 extension, but there are a couple of potential candidates remaining not addressed in that PR that might have this issue:
https://github.com/apache/incubator-druid/blob/master/indexing-hadoop/src/main/java/org/apache/druid/indexer/JobHelper.java#L771
https://github.com/apache/incubator-druid/blob/master/extensions-contrib/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureDataSegmentPusher.java#L130

Contributor guide

Open the contributing guide

Research direction

Start with the S3 URI-escaping changes discussed in PR #8903, then inspect indexing-hadoop/src/main/java/org/apache/druid/indexer/JobHelper.java at line 771 and extensions-contrib/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureDataSegmentPusher.java at line 130. Confirm whether these and any other cloud object path handling still omit escaping, and consider the work complete when all identified paths are handled consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, azure, java
Domain
cloud
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.