Fix double-checked locking in predicate suppliers in BoundDimFilter, InDimFilter, SelectorDimFilter
Open
Area - Querying
Bug
Contributions Welcome
- Dominant language
- Java
- Stars
- 14.1k
- Forks
- 3.8k
- Avg merge
- 2d 58m
- Merged PRs (30d)
- 233
Description
Similar to #6662. These instances of double-checked locking were not identified in that PR.
For anyone who is willing to do this: please read this thread carefully: https://github.com/apache/incubator-druid/pull/6662#discussion_r236302382
Contributor guide
Research direction
Read the discussion linked from PR #6662 before examining the predicate suppliers in BoundDimFilter, InDimFilter, and SelectorDimFilter. Compare these instances with the double-checked locking addressed there, then verify that all three classes no longer contain the unsafe pattern and that existing tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100