apache / apache/druid

System.currentTimeMillis() should not be used for time comparisons in SeekableStreamIndexTaskRunner

Open
#8,505 0 comments 0 reactions 0 assignees View on GitHub
Area - Streaming Ingestion Bug
Dominant language
Java
Stars
14.1k
Forks
3.8k
Avg merge
2d 58m
Merged PRs (30d)
233

Description

https://github.com/apache/incubator-druid/blob/fba92ae469b512cca6cdf86ffc1c1a2090808453/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java#L709

See https://github.com/code-review-checklists/java-concurrency#time-going-backward

/cc @jihoonson

Thanks to @richardstartin for pointing this out.

Contributor guide

Open the contributing guide

Research direction

Open indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java at line 709 and read the linked Java concurrency guidance on time going backward. Identify the time comparison using System.currentTimeMillis(); done when that comparison no longer depends on wall-clock time and the runner's behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
data-engineering
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.