apache / apache/druid

Add concurrent access documentation to BufferAggregator.relocate()

Open
#8,411 0 comments 0 reactions 0 assignees View on GitHub
Improvement
Dominant language
Java
Stars
14.1k
Forks
3.8k
Avg merge
2d 58m
Merged PRs (30d)
233

Description

As far as I can tell, currently it should say `relocate() is used only in GroupBy implementation in a single-threaded environment; it cannot be called concurrently with get() or aggregate()`, however, @himanshug's growable proposal (https://github.com/apache/incubator-druid/issues/6743#issuecomment-509415145) assumes this method to be called during indexing as well, so it might make sense to add future-proof propositions.

/cc @jihoonson

Contributor guide

Open the contributing guide

Research direction

Locate BufferAggregator.relocate() and read its current documentation alongside get() and aggregate(). Review the linked growable proposal in issue 6743 for the indexing context; done means the method’s concurrent-access constraints and any agreed future-proof wording are documented clearly.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.