apache / apache/druid

Facilitate testing AggregatorFactory (e. g. its makeAggregateCombiner() method) and AggregateCombiner

Open
#7,340 3 comments 0 reactions 0 assignees View on GitHub
Area - Testing
Dominant language
Java
Stars
14.1k
Forks
3.8k
Avg merge
2d 58m
Merged PRs (30d)
233

Description

`AggregateCombiner` is currently hard to test because it accepts works with `ColumnValueSelector` containers rather than with simple object values. At very least, a "singleton" implementation of `ColumnValueSelector` should be provided. Better, there should be something like a mini-framework for testing different cases about aggregator factories. This framework should pay off well because there are so many AggregatorFactories in the codebase.

Related to #7329.

Contributor guide

Open the contributing guide

Research direction

Start by reading AggregatorFactory, its makeAggregateCombiner() method, AggregateCombiner, and ColumnValueSelector, then review related issue #7329. Done means a singleton ColumnValueSelector is available at minimum, with a reusable testing approach for different aggregator-factory cases if the broader framework is pursued.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.