apache / apache/druid

AggregatorFactory.getMergingFactory() and getCombiningFactory() are too similar

Open
#7,288 3 comments 0 reactions 0 assignees View on GitHub
Contributions Welcome Refactoring
Dominant language
Java
Stars
14.1k
Forks
3.8k
Avg merge
2d 58m
Merged PRs (30d)
233

Description

Even after reading Javadoc of both, I don't understand why both methods exist and what is the difference between them. There likely should be just one method.

Related to #7287, #6858, #7019.

Contributor guide

Open the contributing guide

Research direction

Start by reading the Javadocs for AggregatorFactory.getMergingFactory() and getCombiningFactory(), then review related issues #7287, #6858, and #7019. Done requires reaching and documenting a clear decision about whether the methods differ and whether the API should retain or consolidate them.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend-api-design, databases
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.