Placement of SketchMergeAggregatorFactory.getMergingFactory()
Open
Bug
stale
- Dominant language
- Java
- Stars
- 14.1k
- Forks
- 3.8k
- Avg merge
- 2d 58m
- Merged PRs (30d)
- 233
Description
Shouldn't this method belong to `SketchAggregatorFactory`, like for `DoublesSketchAggregatorFactory.getMergingFactory()` and other similar aggregators?
Related to #6858.
FYI @AlexanderSaydakov
Contributor guide
Research direction
Locate SketchMergeAggregatorFactory.getMergingFactory() and compare its placement with SketchAggregatorFactory and DoublesSketchAggregatorFactory.getMergingFactory(). Read the related implementation and existing tests, then confirm the method belongs on SketchAggregatorFactory and that the aggregator behavior and tests remain consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100