apache / apache/druid

Improve OverlordResourceTest to actually verify API calls

Open
#6,685 3 comments 0 reactions 0 assignees View on GitHub
Area - Testing stale
Dominant language
Java
Stars
14.1k
Forks
3.8k
Avg merge
2d 31m
Merged PRs (30d)
209

Description

Currently OverlordResourceTest is calling Java methods directly instead of calling HTTP endpoints. This sometimes makes somethings to test hard. For example, https://github.com/apache/incubator-druid/pull/6679 isn't easy to test by directly calling Java methods. Testing resourceFilters is also difficult.

Probably this test can be improved using jersey-test-framework or something else similar. Also we may need to consider upgrading jersey first.

Contributor guide

Open the contributing guide

Research direction

Start with OverlordResourceTest and inspect how it currently invokes Java methods directly. Review jersey-test-framework and the possible Jersey upgrade before choosing the test setup. Done means the test exercises HTTP endpoints and can cover cases such as resourceFilters, including the behavior described in PR 6679.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.