apache / apache/directory-scimple

@XmlElement(nillable=true) annotation on type properties causes json serialization to include null values

Open Beginner friendly
#1,229 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
103
Forks
47
Avg merge
3d 15h
Merged PRs (30d)
16

Description

`type` properties are annotated with `@XmlElement(nillable=true)`.

This causes `"type":null` to be output in the json seralization of the corresponding objects in user resources (for Email, Entitlement, Role, Im, Photo, X509Certificate).

I tried with `@XmlElement`, removing `(nillable=true)`, and this seems to produce the expected results and doesn't seem to cause issues on a quick test.

Is `nillable=true` necessary, or can we remove it?

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the Email, Entitlement, Role, Im, Photo, and X509Certificate resource types for @XmlElement(nillable=true) on their type properties. First reproduce JSON serialization with a null type, then compare behavior after removing nillable=true. Done means null type fields are omitted from user-resource JSON without causing issues in the existing quick-test scenarios.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.