Keep track of common sub-expression across logical plan nodes
- Dominant language
- Rust
- Stars
- 9.3k
- Forks
- 2.4k
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 344
Description
### Is your feature request related to a problem or challenge?
_No response_
### Describe the solution you'd like
Currently, common `CommonSubexprEliminate` `LogicalPlan` optimizer rule analyzes common sub-expressions in a query. Then caches, common sub-expression by adding a `LogicalPlan::Projection` if it thinks this is beneficial.
As an example, following query
```sql
SELECT c3+c4, SUM(c3+c4) OVER(order by c3+c4)
FROM t
```
generates following `LogicalPlan`:
```
Projection: t.c3 + t.c4, SUM(t.c3 + t.c4) ORDER BY [t.c3 + t.c4 ASC NULLS LAST] RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW
--WindowAggr: windowExpr=[[SUM(CAST(t.c3 + t.c4t.c4t.c3 AS t.c3 + t.c4 AS Int64)) ORDER BY [t.c3 + t.c4t.c4t.c3 AS t.c3 + t.c4 ASC NULLS LAST] RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW AS SUM(t.c3 + t.c4) ORDER BY [t.c3 + t.c4 ASC NULLS LAST] RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW]]
----Projection: t.c3 + t.c4 AS t.c3 + t.c4t.c4t.c3, t.c3, t.c4
------TableScan: t projection=[c3, c4]
```
where `t.c3+t.c4` is calculated once in the `Projection` then referred by subsequent `WindowAggr` as a column.
However, following query:
```sql
SELECT c3+c4, SUM(c3+c4) OVER()
FROM t
```
generates following `LogicalPlan`:
```
Projection: t.c3 + t.c4, SUM(t.c3 + t.c4) ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING
--WindowAggr: windowExpr=[[SUM(CAST(t.c3 + t.c4 AS Int64)) ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING]]
----TableScan: t projection=[c3, c4]
```
instead we could generate following plan:
```
Projection: col(t.c3 + t.c4), SUM(t.c3 + t.c4) ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING
--WindowAggr: windowExpr=[[SUM(CAST(col(t.c3 + t.c4) AS t.c3 + t.c4 AS Int64)) ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING]]
----Projection: t.c3 + t.c4 AS col(t.c3 + t.c4)
------TableScan: t projection=[c3, c4]
```
If were to keep track of common sub expression counts globally across different nodes in the `LogicalPlan`. This will enable us to generate better `LogicalPlan`s.
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
Contributor guide
Research direction
Start with the CommonSubexprEliminate logical-plan optimizer rule and compare the two example plans in the issue. Trace how common sub-expression counts are maintained across LogicalPlan nodes. Done means the optimizer can recognize the shared expression across the window and projection nodes and produce the improved plan shown.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust, sql
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100