Add test coverage for grouping on dictionary encoded columns
- Dominant language
- Rust
- Stars
- 9.3k
- Forks
- 2.4k
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 344
Description
### Is your feature request related to a problem or challenge?
At InfluxData we use `Dictionary(Int32, Utf8)` heavily for certain columns of our queries.
This particular type of data is not well represented in the DataFusion codebase, which leads to issues such as https://github.com/apache/arrow-datafusion/issues/8738
In addition to not being well covered by functional tests, we also don't have particularly good coverage performance wise, especially for some of our important cases like grouping performance. This leads to dueling speculations on better/worse ways to run such queries, such as https://github.com/apache/arrow-datafusion/issues/7647 but now good way to evaluate them
### Describe the solution you'd like
I would like to ensure we have adequate test coverage
1. Functional tests so we don't hit regressions accidentally again
2. Performance tests (e.g. so we could evaluate the changes contemplated by https://github.com/apache/arrow-datafusion/issues/7647
### Describe alternatives you've considered
I added some functional sqllogictests in
* https://github.com/apache/arrow-datafusion/blob/main/datafusion/sqllogictest/test_files/dictionary.slt
However, those are not reading from Parquet files (as I could not figure out how to make a parquet file have the same schema I wanted)
### Additional context
_No response_
Contributor guide
Assessment
This issue has not been assessed yet.