Remove ScalarValue Ord / PartialOrd
- Dominant language
- Rust
- Stars
- 9.3k
- Forks
- 2.4k
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 344
Description
### Is your feature request related to a problem or challenge?
The performance of sorting ScalarValue directly will be exceptionally poor, especially when compared to vectorised approaches operating on arrays or rows, and having separate mechanisms introduces opportunity for inconsistency.
### Describe the solution you'd like
Remove PartialOrd and Ord from ScalarValue
### Describe alternatives you've considered
_No response_
### Additional context
#7353 #7352 both track using ArrayRef within ScalarValue which this would relate to
Contributor guide
Research direction
Locate ScalarValue and its PartialOrd and Ord implementations, then read the related discussions in #7353 and #7352 about using ArrayRef within ScalarValue. The work is complete when ScalarValue no longer implements either ordering trait and the relevant test suite passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100