apache / apache/datafusion

Sqllogictests doesn't cover cases if the column name is not expected.

Open
#6,349 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

### Is your feature request related to a problem or challenge?

As we port our tests to sqllogictests https://github.com/apache/arrow-datafusion/issues/4460 it is important to retain test coverage

One thing that was noticed is that sqllogictest tests doesn't cover cases if the column name is not expected.

So for example, it will show the following outputs as the same

| Int8 |
|--------|
| 1 |
| 2 |

to

| a |
|--------|
| 1 |
| 2 |

### Describe the solution you'd like

It would be nice to have some way (perhaps optionally) that verified the column names as well

### Describe alternatives you've considered

_No response_

### Additional context

@comphead brought thus up on https://github.com/apache/arrow-datafusion/pull/6329#pullrequestreview-1425450768

Contributor guide

Open the contributing guide

Research direction

Read the sqllogictests porting context in issue #4460 and the review discussion on pull request #6329, then trace the existing sqllogictests result verification. Define how optional column-name checking should work and add coverage for the Int8 and a-column examples; done means mismatched names are detected when that checking is enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, sql
Domain
testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.