apache / apache/datafusion

Run some datafusion tests under MIRI

Open
#3,611 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
[MIRI](https://github.com/rust-lang/miri) is a memory checker for rust , something like valgrind

DataFusion at some point in the far distant past ran MIRI to ensure there was no undefined behavior. However, it was broken and removed in https://github.com/apache/arrow-datafusion/pull/3610

**Describe the solution you'd like**
- [ ] Review what parts of the datafusion codebase make sense to run under MIRI (perhaps the `datafusion-physical-expr` crate where there are some uses of `unsafe`?)
- [ ] Add a MIRI check (see https://github.com/apache/arrow-datafusion/pull/3610 for an example) that works and runs MIRI for that codebase
- [ ] Fix any issues that MIRI flags

**Describe alternatives you've considered**
Don't run MIRI

**Additional context**
MIRI is run against the various crates in arrow / parquet

Contributor guide

Open the contributing guide

Research direction

Review the prior MIRI setup in pull request 3610 and inspect the datafusion-physical-expr crate, especially its unsafe usage, to identify suitable tests. Add a working MIRI check for the selected code and run it against the relevant tests. Done means the check runs successfully and any issues it reports are fixed.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
ci-cd, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.