apache / apache/datafusion

Account for memory used in SortKeyCursor by row format (spilling Sort)

Open
#3,609 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
As noted by @yjshen in https://github.com/apache/arrow-datafusion/pull/3386/files#r966573456, https://github.com/apache/arrow-datafusion/pull/3386 switches DataFusion to use a faster comparison method, but does not update the used memory calculation.

**Describe the solution you'd like**
We need to track the total memory used by all cursors since the cursor now holds Rows.

**Describe alternatives you've considered**
N/A

**Additional context**
See above

Contributor guide

Open the contributing guide

Research direction

Start by reading PR #3386 and then trace the SortKeyCursor entry point used by spilling Sort. Confirm how cursors hold Rows and how memory is currently calculated; the work is done when total memory used by all cursors is included in that calculation.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend, data-engineering
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.