apache / apache/datafusion

Remove `enforce_batch_size_in_joins` in symmetric hash join, and deprecate the config

Open
#24,812 2 comments 0 reactions 1 assignee Claimed by @saadtajwar View on GitHub
enhancement
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

### Is your feature request related to a problem or challenge?

Background: - https://github.com/apache/datafusion/pull/12969

No this config is not used in most other operators, and SHJ is the only place using it. Outputting incrementally seems to be always better (the behavior when `enforce_batch_size_in_joins` set to true), so we can only keep this behavior and deprecate the config.

### Describe the solution you'd like

1. Change SHJ implementation to always output incrementally
2. Deprecate the `enforce_batch_size_in_joins` config (https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines)

### Describe alternatives you've considered

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.