apache / apache/datafusion

Simplify `AggregateHashTable<PartialSkip>`

Open
#23,113 0 comments 0 reactions 1 assignee Claimed by @2010YOUY01 View on GitHub
enhancement
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

### Is your feature request related to a problem or challenge?

- https://github.com/apache/datafusion/issues/22710

In the above EPIC's aggregate refactor, it's now using a variant of `AggregateHashTable` to handle the `convert_to_states()` optimization (see https://github.com/apache/datafusion/pull/22899 for this optimization)
https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/aggregates/hash_table.rs#L601

The only needed fields are only `GroupsAccumulators`, and we don't have to carry along the heavy hash table, so we can simplify `AggregateHashTable` into a simpler struct.

### Describe the solution you'd like

_No response_

### Describe alternatives you've considered

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.