Suggestion: enable `unreachable_pub` lint at workspace level
- Dominant language
- Rust
- Stars
- 9.3k
- Forks
- 2.4k
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 344
Description
Why looking at the code I thought I could use `InProgressSpillFile` since it marked as `pub`, or the function `create_in_progress_file` that is also `pub`, but `InProgressSpillFile` mod is behind `pub(crate)` so to avoid confusion when reading the source code
I want to enable `unreachable_pub` lint at the workspace level so this won't happen since you will be forced to specify the correct visibility
Applying this can be done using: `cargo fix --workspace --all-targets`
Contributor guide
Research direction
Start at the workspace-level Cargo configuration and inspect how lint settings are currently defined. Run `cargo fix --workspace --all-targets`, review the visibility changes it proposes, and verify that the workspace builds and the `unreachable_pub` lint is enabled without remaining warnings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system, tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100