apache / apache/datafusion

Consider disallowing std hashmap/hashset via clippy

Open
#19,869 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

We have a clippy config for disallowing types:

https://github.com/apache/datafusion/blob/3ea21aa332b2916e59b446317868a9ecffb30022/clippy.toml#L6-L8

In `datafusion-common` we re-export hashbrown hashmaps/hashsets to encourage usage of them over std versions:

https://github.com/apache/datafusion/blob/3ea21aa332b2916e59b446317868a9ecffb30022/datafusion/common/src/lib.rs#L113-L121

- https://github.com/apache/datafusion/pull/13236
- https://github.com/apache/datafusion/issues/677

Consider using clippy to enforce this?

Contributor guide

Open the contributing guide

Research direction

Start with clippy.toml and datafusion/common/src/lib.rs, then inspect the existing disallowed types and usages of standard hash maps and hash sets across the repository. Run the relevant Clippy checks to identify violations; done means the intended standard types are consistently rejected while the datafusion-common re-exports remain usable.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.