Clean up duplicate types in `sql` module
- Dominant language
- Rust
- Stars
- 9.3k
- Forks
- 2.4k
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 344
Description
After https://github.com/apache/datafusion/pull/17332, we can make the `datafusion-expr` crate not depend on sqlparser-rs (and copy the relevant types that are needed).
The expr crate should become un-dependent from sqlparser::ast types, so these copies should be the only types we use.
Is there a follow-up issue planned to cleanup these duplicate types?
_Originally posted by @findepi in https://github.com/apache/datafusion/pull/17332#discussion_r2355658394_
Contributor guide
Research direction
Start by reviewing PR 17332 and the datafusion-expr crate's uses of sqlparser::ast types. Identify the copied types that should remain in the expr crate and verify which sqlparser dependency and duplicate definitions can be removed. Done means datafusion-expr no longer depends on sqlparser-rs and uses only its local copies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust, sql
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100