Discuss: not update Cargo.toml minor/patch version?
- Dominant language
- Rust
- Stars
- 9.3k
- Forks
- 2.4k
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 344
Description
Hi, I see we've checked in `Cargo.lock` recently #14135, and I think it's good!
But I'm not sure whether this was discussed: what about not updating `Cargo.toml` (for minor/patch versions), but only `Cargo.lock`?
From the discussion, I can see the main motivation is to have reproducible build (agains near latest dependencies) in CI. To achieve this, `Cargo.lock` (updated by bot) is enough.
Whether or not updating `Cargo.toml` means whether or not _force_ downstream users to use only the latest dependency versions. Personally I prefer a more tolerable version range, so that downstream can update deps 1 by 1 and audit each dep's changes.
FYI in iceberg-rust, we have similar discussions on this topic, and we prefer to have a wider range of versions support, to allow users to choose their dep version (by not updating Cargo.toml too often) https://lists.apache.org/thread/pv3onm41229lovs1odqg94fdc60wcp73
Contributor guide
Research direction
Start by reviewing the repository's Cargo.toml and Cargo.lock history, including the context from issue #14135 and the linked iceberg-rust discussion. Determine the project's preferred minor and patch dependency update policy; done would be a maintainer decision that clearly documents whether Cargo.toml, Cargo.lock, or both should be updated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100