apache / apache/datafusion

Add tests for new parser options

Open
#14,900 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

Thanks @niebayes -- this makes sense to me

Could we please add some sort of test to amke sure we don't accidentally break this in the future? Like maybe a query that requires `enable_ident_normalization` ?

_Originally posted by @alamb in https://github.com/apache/datafusion/pull/14822#pullrequestreview-2641651180_

Contributor guide

Open the contributing guide

Research direction

Start by locating the parser option `enable_ident_normalization` and the existing parser or query tests. Add a query-based test that exercises this option and verifies the expected behavior, as requested in the issue; done means the test prevents the new parser option from regressing.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, sql
Domain
backend-api-design, testing-qa
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.