apache / apache/datafusion

Update recursion limit in DataFusion

Open
#14,857 1 comment 0 reactions 1 assignee Claimed by @Omega359 View on GitHub
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

As mentioned in https://github.com/apache/datafusion/pull/14095#issuecomment-2679018958 and discovered in https://github.com/apache/datafusion/issues/14091 it seems that we could look into increasing the recursion limit to allow more sql tests to pass without cause stack overflows.

This ticket is to investigate just how much the recursion limit would need to be increased to allow queries such as in https://github.com/apache/datafusion/issues/14091 to pass without issues. Once that limit is found we could update DF with that as the default recursion limit.

This change will require changes to DFParser and likely a new config option. The default recursion limit is 50 as seen @ https://github.com/apache/datafusion-sqlparser-rs/blob/aab12add36bfb4dfd60c2ba38682b503cc248199/src/parser/mod.rs#L187

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.