apache / apache/datafusion

Enhance msrv check to check all crates

Open
#14,022 0 comments 1 reaction 0 assignees View on GitHub
development-process
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

I wonder if should be checking more (or all) crates here?

https://github.com/apache/datafusion/blob/b8b0c5584f9f3a3aeca730ef1ac23dafc3e76dde/.github/workflows/rust.yml#L594-L641

See arrow-rs PR for reference which identified a similar issue there: https://github.com/apache/arrow-rs/pull/6742

_Originally posted by @Jefffrey in https://github.com/apache/datafusion/pull/14009#pullrequestreview-2530810617_

Contributor guide

Open the contributing guide

Research direction

Start with the MSRV check in .github/workflows/rust.yml at lines 594-641, then compare its crate coverage with the arrow-rs PR referenced in the issue. Determine which DataFusion crates are currently omitted; done means the workflow checks all intended crates and the MSRV job passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, rust
Domain
ci-cd
Issue type
Feature
Difficulty
3/5
Estimated time
Half a day
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.