apache / apache/datafusion

Refactor `TableFunctionImpl` to a separate module

Open
#13,613 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

### Is your feature request related to a problem or challenge?

Background: https://github.com/apache/datafusion/pull/13540#discussion_r1857679120
After https://github.com/apache/datafusion/pull/13540 is merged, there is a refactor can be done:
- Move `TableFunctionImpl` to a separate module
- Add `name()` method under the trait to keep it consistent with other functions (Like user-defined aggregate function)

### Describe the solution you'd like

_No response_

### Describe alternatives you've considered

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the discussion in https://github.com/apache/datafusion/pull/13540#discussion_r1857679120 and locate TableFunctionImpl in the current DataFusion source. Done means the implementation is in a separate module and the trait exposes a name() method consistent with the other function traits; the issue names no tests to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.