apache / apache/datafusion

Remove `opt_filter` optional parameter in GroupsAccumulator:merge

Open
#13,484 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

That is why I return error for now, we can remove the `opt_filter` after couple of months

_Originally posted by @jayzhan211 in https://github.com/apache/datafusion/pull/13463#discussion_r1847462304_

The idea is that the parameter is never used, so we can remove it to simplify GroupsAccumulator implementations.

@jayzhan211s PRs above throws an error if this assumption is not true.

If we haven't hit any errors in a few months, we should just remove the parameter entirely

Contributor guide

Open the contributing guide

Research direction

Start by searching the Rust codebase for GroupsAccumulator::merge and the opt_filter parameter, then review the implementations and the PR discussion linked in the issue. Confirm that the parameter is unused and that the existing error checks are no longer needed; done means the parameter is removed consistently without triggering the previously guarded errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.