apache / apache/datafusion

Remove manual `PartialEq` and `Hash` implementations of some `PhysicalExpr`s added in https://github.com/apache/datafusion/pull/13005

Open
#13,196 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

### Describe the bug

This is a TODO ticket that once the https://github.com/rust-lang/rust/issues/78808 bug gets fixed we can switch from manual implementation of `PartialEq` and `Hash` of all `PhysicalExprs`s to `derive` macro.
See details in https://github.com/apache/datafusion/pull/13005 description and https://github.com/apache/datafusion/pull/13005#discussion_r1824074787.

### To Reproduce

_No response_

### Expected behavior

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reading pull request 13005 and discussion 1824074787, then check Rust issue 78808 to confirm whether its blocker is fixed. Done means replacing the manual PartialEq and Hash implementations for the PhysicalExprs with derive macros once that fix is available.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.