apache / apache/datafusion

Keep the original SQL for CreateExternalTable::definition

Open
#12,652 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

### Is your feature request related to a problem or challenge?

Currently, the CreateExternalTable definition is just a stringified version of the statement, rather than the original SQL that was parsed.

### Describe the solution you'd like

I'd like to propose capturing the original SQL as provided and storing that instead so that when a definition is displayed, it matches what a user originally provided.

### Describe alternatives you've considered

Nothing comes to mind. Its a fairly small change.

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by locating CreateExternalTable::definition and follow how the statement is parsed and its definition is stored. Check the existing tests around CreateExternalTable display or parsing, then verify that the displayed definition preserves the SQL originally provided rather than a stringified statement.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, sql
Domain
databases
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.