apache / apache/datafusion

Improve aggregation code readability

Open
#12,335 8 comments 3 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

### Is your feature request related to a problem or challenge?

I'm reading aggregation code recently, found it's hard to read due to different `AggregateMode`, these modes are mixed up in the code.

### Describe the solution you'd like

Might split stream based on `AggregateMode`?

### Describe alternatives you've considered

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

No file, test, or entry point is identified in the issue. Start by locating the aggregation code and references to `AggregateMode`, then determine how the modes are currently mixed and what stream split is intended; done means the aggregation code is more readable without changing its behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
data-engineering
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.