apache / apache/datafusion

Simplify the `name` function in datafusion

Open
#11,782 1 comment 1 reaction 1 assignee Claimed by @jayzhan211 View on GitHub
enhancement
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

### Is your feature request related to a problem or challenge?

There are `display_name`, `create_name`, `write_name`, `impl fmt::Display for Expr`, `create_function_physical_name`, `create_physical_name`, `physical_name`..

I hope we can have much more simplified and easy to use name function.
If we can standardize logical namd and physical name is a big plus. IIRC, the only expression that has gap between logical and physical name is Cast, and we probably do not need to.

This could also help https://github.com/apache/datafusion/issues/10274 a lot

### Describe the solution you'd like

ideally we could keep `impl fmt::Display for Expr` and use `format!()` to get the String for `display_name`🤔
And, minimize the gap between logical name and physical name.

### Describe alternatives you've considered

_No response_

### Additional context

https://github.com/apache/datafusion/pull/11724#discussion_r1698786265

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.