Review code that `downcast_ref` from `CatalogSession` to `SessionState`
- Dominant language
- Rust
- Stars
- 9.3k
- Forks
- 2.4k
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 344
Description
https://github.com/apache/datafusion/pull/11516 added `downcast_ref` to `SessionState` in couple places with TODO comments. These places should be revised. Perhaps `CatalogSession` API should be extended so that downcast is not needed, or functionality refactored (e.g. as proposed here: https://github.com/apache/datafusion/pull/11516#discussion_r1686655186).
## Context
- https://github.com/apache/datafusion/pull/11516
Contributor guide
Research direction
Start by reviewing the CatalogSession and SessionState downcast_ref call sites introduced by pull request 11516, including its linked discussion. Determine whether the CatalogSession API or surrounding functionality should change, then confirm that the TODO-marked uses are revised without relying on those downcasts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100