ExprBuilder for Physical Aggregate Expr
- Dominant language
- Rust
- Stars
- 9.3k
- Forks
- 2.4k
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 344
Description
### Is your feature request related to a problem or challenge?
While I working on `OrderSensitiveArrayAgg`, I found we again need to add another field `is_reversed`, indicate whether the expression is reversed or not, it is currently used specific for `OrderSensitiveArrayAgg`, but I still think we can only add it the function `create_aggregate_expr`.
I wonder would it be helpful to have the expression builder to replace this function at all, I think the change could probably minimze breaking change if we are going to add / remove field inside `create_aggregate_expr` in the future
### Describe the solution you'd like
_No response_
### Describe alternatives you've considered
Keep `create_aggregate_expr`
### Additional context
_No response_
Contributor guide
Research direction
Start by locating create_aggregate_expr and the OrderSensitiveArrayAgg implementation referenced in the issue. Review how aggregate expressions are constructed and identify the compatibility and API implications of replacing the function with an expression builder. Done means the builder's scope and behavior are defined and the requested construction path is implemented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, data
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100