apache / apache/datafusion

Better aggregate support for StringViewArray

Open
#11,418 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
9.3k
Forks
2.4k
Avg merge
3d 7h
Merged PRs (30d)
344

Description

### Is your feature request related to a problem or challenge?

Current aggregate makes a special case for Utf8/LargeUtf8 that does not go through the arrow-row format. https://github.com/apache/datafusion/blob/string-view/datafusion/physical-plan/src/aggregates/group_values/mod.rs#L70C4-L81

We should do this to Utf8View/BinaryView as well.

### Describe the solution you'd like

_No response_

### Describe alternatives you've considered

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start in datafusion/physical-plan/src/aggregates/group_values/mod.rs, especially the existing Utf8/LargeUtf8 special case. Compare that handling with the aggregate path for Utf8View/BinaryView and determine how the arrow-row format is currently bypassed. Done means Utf8View and BinaryView receive equivalent aggregate support.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.