apache / apache/datafusion-sqlparser-rs

Improving support for `CREATE PROCEDURE`

Open
#1,902 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
3.5k
Forks
772
Avg merge
4d 9h
Merged PRs (30d)
17

Description

sqlparser-rs currently doesn't have great support for `CREATE PROCEDURE` statements, leading to parser errors when I pass in valid SQL. I'd like to work on improving this (I've already started on [my fork](https://github.com/ZacJW/sqlparser-rs/tree/dev)).

What's the project's ideal vision for how this would be handled? Stored procedures are the kind of thing that can be very RDBMS specific. Do you just want the AST to cover what's in the standard, but the dialects to accept but discard additional options?

The first fix which will be ready to go once I've written tests is #1901, support for what PostgreSQL calls argmode and the standard calls parameter mode.

## PRs

- #1901
- #1903

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the existing work on the author's fork's dev branch and the linked issues and PRs #1901 and #1903. Clarify the project's intended AST and dialect behavior for CREATE PROCEDURE, then add tests covering the agreed support so valid SQL parses as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, sql
Domain
compilers, databases
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.