apache / apache/datafusion-sqlparser-rs

`GenericDialect` should support multi-table DELETE and DELETE without FROM clause

Open
#1,846 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
3.5k
Forks
772
Avg merge
4d 9h
Merged PRs (30d)
17

Description

According to the design policy, `GenericDialect` is intended to parse any SQL that other dialects can handle, but it currently fails to parse multi-table DELETE statements and DELETE statements without a FROM clause.

I think the expected behavior is that the following tests should also pass with `GenericDialect`.

https://github.com/apache/datafusion-sqlparser-rs/blob/2182f7ea71242a7e9674932d559baef67dae522d/tests/sqlparser_common.rs#L688-L735

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with tests/sqlparser_common.rs lines 688-735 and run the referenced tests using GenericDialect. Trace the parsing path for multi-table DELETE statements and DELETE statements without a FROM clause. Done means both existing test groups pass with GenericDialect.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, sql
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.