apache / apache/datafusion-sqlparser-rs

Expand Trigger parsing support

Open
#1,388 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
3.5k
Forks
772
Avg merge
4d 9h
Merged PRs (30d)
17

Description

Hi folks,

Thanks @LucaCappelletti94 for stepping in. I was very excited to see "CREATE TRIGGER" support landing.

I just tried it it out and noticed that it's implemented for the Postgres and Generic dialects only, which is a great. I was wondering if there are any plans to extend support to other dialects? I'm most interest in sqlite: https://www.sqlite.org/lang_createtrigger.html with the biggest difference being inline functions bodies vs "execute function_name"

Thanks!

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the existing CREATE TRIGGER parsing support for the Postgres and Generic dialects, then compare it with SQLite's CREATE TRIGGER syntax at the linked SQLite documentation. Done means SQLite trigger statements, including inline function bodies, are accepted and covered by appropriate parser tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, sqlite
Domain
databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.