apache / apache/datafusion-comet

docs: Update "Adding a New Expression" to reference SQL file tests

Open
#3,406 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Scala
Stars
1.3k
Forks
373
Avg merge
2d 4h
Merged PRs (30d)
198

Description

### What is the problem the feature request solves?

We've had a number of recent PRs adding new expressions (which is phenomenal!) that I have to ask to add/migrate tests to the new SQL file test framework (https://datafusion.apache.org/comet/contributor-guide/sql-file-tests.html).

### Describe the potential solution

Add a link to SQL file tests https://datafusion.apache.org/comet/contributor-guide/sql-file-tests.html on the "Adding a New Expression" page and mention it in how to test.

https://datafusion.apache.org/comet/contributor-guide/adding_a_new_expression.html

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.