apache / apache/datafusion-comet

Improve fallback reporting for aggregates

Open
#2,787 0 comments 0 reactions 1 assignee Claimed by @andygrove View on GitHub
enhancement
Dominant language
Scala
Stars
1.3k
Forks
373
Avg merge
2d 4h
Merged PRs (30d)
198

Description

### What is the problem the feature request solves?

If incompatible casts are not enabled, I see the following fallback message in `spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark4_0/q92.native_iceberg_compat/extended.txt` when running the plan stability suite.

The fallback message does not suggest enabling incompatible casts, so is not very helpful.

```
+- HashAggregate [COMET: Unsupported result expressions found in: List((1.3 * cast((avg(UnscaledValue(ws_ext_discount_amt#1))#2 / 100.0) as decimal(11,6))) AS (1.3 * avg(ws_ext_discount_amt))#3, ws_item_sk#4)]
```

### Describe the potential solution

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.