apache / apache/datafusion-comet

Review names of configuration settings

Open
#2,601 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Scala
Stars
1.3k
Forks
373
Avg merge
2d 4h
Merged PRs (30d)
198

Description

### What is the problem the feature request solves?

The configuration settings have many inconsistencies.

For example, we have many different prefixes for shuffle-related configs:

- `spark.comet.columnar.shuffle`
- `spark.comet.exec.shuffle`
- `spark.comet.native.shuffle`
- `spark.comet.shuffle`

There are also differences in convention for naming within configs:

- `mergeRanges` (Camel Case)
- `thread-pool` (Hyphenated)
- `read.parallel.io` (dot separated)

Renaming any of these configs will be disruptive to users. If we do rename them, I suggest we do it for the 1.0.0 release.

We could also consider introducing a capability to support the old deprecated names for some period of time.

### Describe the potential solution

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.