apache / apache/daffodil-vscode

Bug: Data Editor Shows Highlighted Bytes in all Data Editor tabs during debugging

Open
#1,469 4 comments 0 reactions 1 assignee Claimed by @stricklandrbls View on GitHub
bug code quality data editor extension typescript
Dominant language
TypeScript
Stars
18
Forks
33
Avg merge
3d 6h
Merged PRs (30d)
7

Description

## Description

When multiple data editor tabs are opened prior to starting a DFDL debugging session and the other data editor tabs are open, the red highlighted byte shows in all of the data editor tabs (even for DE tabs that have a file opened other than the data file in the DFDL debugging session)

Originally noted by @stricklandrbls in https://github.com/apache/daffodil-vscode/pull/1463#issuecomment-3408920864

## Steps to Reproduce

1. Open data editor tab(s) via command palette

Image

2. Launch a DFDL debugging session where `"openDataEditor": true,`. An example launch.json config is given below:

```JSON
{
"request": "launch",
"type": "dfdl",
"name": "Wizard Config",
"schema": {
"path": "${command:AskForSchemaName}",
"rootName": null,
"rootNamespace": null
},
"data": "${command:AskForDataName}",
"debugServer": 4711,
"infosetFormat": "xml",
"infosetOutput": {
"type": "file",
"path": "${workspaceFolder}/target/infoset.xml"
},
"tdmlConfig": {
"action": "none"
},
"trace": true,
"stopOnEntry": true,
"useExistingServer": false,
"openDataEditor": true,
"openInfosetView": false,
"openInfosetDiffView": false,
"daffodilDebugClasspath": [],
"dataEditor": {
"port": 9000,
"logging": {
"file": "${workspaceFolder}/dataEditor-${omegaEditPort}.log",
"level": "info"
}
},
"dfdlDebugger": {
"logging": {
"file": "${workspaceFolder}/daffodil-debugger.log",
"level": "INFO"
}
}
}
```

3. Select a DFDL file and a data file that is not one that is previously opened in a Data Editor tab.

4. Set up your tabs to where you see multiple data editor tabs. Then step over a few lines

Image

Note: Data editor tabs that don't have the data file show the red square at the beginning of the file. The data file doesn't until you step over.

## Expected Behavior

The data editor should only show the red byte highlight square for the data file specified in the DFDL debugging session.

## Actual Behavior

The data editor tabs show the red square in the same n-th byte for all data editor tabs, not just the data file itself.

## Additional Notes and Screenshots

See screenshots in the steps section

## Environment

- Operating System(s): W11

- Browser/VS Code version:

Image

- Extension version: 1.5.0 SNAPSHOT

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.