[CURATOR-94] PERMANENT registration should not be added to the services map.
- Dominant language
- Java
- Stars
- 3.2k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
In ServiceDiscoveryImpl the registerService(...) method should be:
{
if (service.getServiceType() == ServiceType.STATIC)
{
services.put(service.getId(), service);
}
internalRegisterService(service);
}
This prevents two side effects:
+ PERMANENT registration are not deleted when the ServiceDiscoveryImpl class is closed.
+ PERMANENT registration are not re-registered (potentially with old data) after a connection loss event.
The first case is a problem, since shutting down the registration app cleanly deletes all PERMANENT registrations.
Additionally since PERMANENT registrations do not use ephemeral nodes the re-registration functionality is not needed.
---
Originally reported by dtrott, imported from: PERMANENT registration should not be added to the services map.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.