apache / apache/curator

[CURATOR-94] PERMANENT registration should not be added to the services map.

Open
#615 4 comments 0 reactions 0 assignees View on GitHub
bug imported-jira-issue
Dominant language
Java
Stars
3.2k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

In ServiceDiscoveryImpl the registerService(...) method should be:

{

if (service.getServiceType() == ServiceType.STATIC)


{
services.put(service.getId(), service);
}

internalRegisterService(service);

}

This prevents two side effects:

+ PERMANENT registration are not deleted when the ServiceDiscoveryImpl class is closed.

+ PERMANENT registration are not re-registered (potentially with old data) after a connection loss event.

The first case is a problem, since shutting down the registration app cleanly deletes all PERMANENT registrations.

Additionally since PERMANENT registrations do not use ephemeral nodes the re-registration functionality is not needed.

---
Originally reported by dtrott, imported from: PERMANENT registration should not be added to the services map.


  • status: Open
  • priority: Major
  • resolution: Unresolved
  • imported: 2025-01-21

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.