apache / apache/curator

[CURATOR-557] ServiceCacheImpl does not close ExecutorService

Open
#1,076 15 comments 0 reactions 0 assignees View on GitHub
bug imported-jira-issue
Dominant language
Java
Stars
3.2k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

ServiceCacheImpl does not close the ExecutorService instance created from the ThreadFactory:

https://github.com/apache/curator/blob/master/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java#L64

 

CloseableExecutorService::CloseableExecutorService(ExecutorService) call this(executorService, false) which sets shutdownOnClose to false.

 

this has an impact from callers, eg ServiceProviderImpl, which only allow only a ThreadFactory to be specified.

 

 

---
Originally reported by rnaude, imported from: ServiceCacheImpl does not close ExecutorService


  • status: Open
  • priority: Major
  • resolution: Unresolved
  • imported: 2025-01-21

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.