apache / apache/couchdb-nano

New Axios-based cookie support has side-effects because of axios-cookiejar-support

Open
#254 3 comments 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
689
Forks
167
Avg merge
1h
Merged PRs (30d)
1

Description

I'm cross-posting this issue here just to let you know that the new usage of axios-cookiejar-support has side effects on unrelated code. As I've described here (https://github.com/auth0/node-jwks-rsa/issues/215), I'm using node-jwks-rsa, which also uses Axios as client. Unfortunately, since nano includes axios-cookiejar-support, it seems that the way node-jwks-rsa uses Axios does not work anymore.

I imagine that they could change the way they use Axios, but it's rather surprising to see such side-effects. Note that it's not an issue with nano per se, but I thought it might be interesting to make it appear here too, in case others stumble upon such problems.

## Expected Behavior
No side-effects with Axios.

## Current Behavior
Axios breaks when used in certain ways because of the presence of axios-cookiejar-support.

## Possible Solution
Fix of axios-cookiejar-support & upgrade of nano (maybe it should also be a peer dependency?)

## Steps to Reproduce (for bugs)

* Add nano to a project
* Import Axios using `import {get} from 'axios'` and try to make a simple request

## Your Environment

* Version used: 9.0.3
* Browser Name and version: N/A
* Operating System and version (desktop or mobile): N/A
* Link to your project: N/A

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the reported interaction with nano, the `axios` named import, and a simple request, using the issue's version and environment details. Compare the behavior with and without nano and review the linked node-jwks-rsa report; done means Axios requests no longer break as a side effect of using nano.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.