apache / apache/cordova

Create shareable ESLint config and use it throughout our repos

Open
#142 6 comments 6 reactions 0 assignees View on GitHub
enhancement
Dominant language
No language data
Stars
710
Forks
75
PR merge metrics
No merged PRs in 30d

Description

# Feature Request

## Motivation Behind Feature

This would make it easier to enforce consistency in our code style while allowing for controlled refinement of it at the same time.

This could also reduce the amount of ESLint related dependencies in the individual repos, if we just require the plugins and base configuration we need in the new shareable config package.

## Feature Description

- Create a [ESLint shareable config](https://eslint.org/docs/developer-guide/shareable-configs)
- Use it in our repos

## Implementation Progress

### Platforms

- [x] cordova-android
- [x] cordova-browser (https://github.com/apache/cordova-browser/pull/96)
- [x] cordova-electron (https://github.com/apache/cordova-electron/pull/113)
- [x] cordova-ios
- [x] cordova-osx
- [ ] cordova-test-platform
- [x] cordova-windows

### Plugins

- [x] cordova-plugin-battery-status
- [x] cordova-plugin-camera
- [x] cordova-plugin-device (https://github.com/apache/cordova-plugin-device/pull/122)
- [x] cordova-plugin-dialogs (https://github.com/apache/cordova-plugin-dialogs/pull/141/)
- [x] cordova-plugin-file (https://github.com/apache/cordova-plugin-file/pull/458)
- [x] cordova-plugin-geolocation (https://github.com/apache/cordova-plugin-geolocation/pull/200)
- [x] cordova-plugin-inappbrowser
- [x] cordova-plugin-media (https://github.com/apache/cordova-plugin-media/pull/283)
- [x] cordova-plugin-media-capture (https://github.com/apache/cordova-plugin-media-capture/pull/179)
- [x] cordova-plugin-network-information
- [x] cordova-plugin-screen-orientation (https://github.com/apache/cordova-plugin-screen-orientation/pull/66)
- [x] cordova-plugin-splashscreen
- [x] cordova-plugin-statusbar (https://github.com/apache/cordova-plugin-statusbar/pull/194)
- [x] cordova-plugin-vibration (https://github.com/apache/cordova-plugin-vibration/pull/89)
- [x] cordova-plugin-whitelist (Deprecated)
- [x] cordova-plugin-wkwebview-engine (https://github.com/apache/cordova-plugin-wkwebview-engine/pull/164)
- [x] cordova-plugin-device-motion
- [x] cordova-plugin-device-orientation
- [x] cordova-plugin-file-transfer

### Tooling

- [x] cordova-cli (https://github.com/apache/cordova-cli/pull/493)
- [x] cordova-coho
- [x] cordova-common (https://github.com/apache/cordova-common/pull/105, https://github.com/apache/cordova-common/pull/109)
- [x] cordova-create (https://github.com/apache/cordova-create/pull/54, https://github.com/apache/cordova-create/pull/55)
- [x] cordova-docs
- [x] cordova-fetch (https://github.com/apache/cordova-fetch/pull/70, https://github.com/apache/cordova-fetch/pull/81)
- [x] cordova-js
- [x] cordova-lib (https://github.com/apache/cordova-lib/pull/822, https://github.com/apache/cordova-lib/pull/828)
- [x] cordova-mobile-spec
- [ ] cordova-node-xcode
- [x] cordova-paramedic
- [x] cordova-plugin-test-framework
- [x] cordova-plugman
- [x] cordova-serve (https://github.com/apache/cordova-serve/pull/23, https://github.com/apache/cordova-serve/pull/25)

**Excluded:**
- cordova-status
- cordova
- cordova-app-hello-world

and any unused, outdated, or deprecated repos_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.