apache / apache/cordova-test-platform

Api.js doesn't follow PlatformRequirements.md

Open
#9 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5
Forks
7
PR merge metrics
No merged PRs in 30d

Description

https://github.com/apache/cordova-test-platform/blob/master/src/cordova/Api.js vs. https://github.com/apache/cordova-test-platform/blob/master/PlatformRequirements.md

1.

https://github.com/apache/cordova-test-platform/blob/4d2212c9a46bc142bb91fa3e69e99d041e8c8221/src/cordova/Api.js#L125-L128

vs.

https://github.com/apache/cordova-test-platform/blob/master/PlatformRequirements.md#platformapiprototyperequirements--function-
> The .requirements must return a promise, resolved with a set of Requirement objects for the current platform.

Returns `true`

2.

https://github.com/apache/cordova-test-platform/blob/4d2212c9a46bc142bb91fa3e69e99d041e8c8221/src/cordova/Api.js#L116-L118

vs

https://github.com/apache/cordova-test-platform/blob/master/PlatformRequirements.md#platformapiprototyperun--functionrunoptions-
> .run must return a promise either fulfilled if the package was build and ran successfully, or rejected with a CordovaError.

Returns nothing

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.