apache / apache/cordova-plugin-inappbrowser

Accidentally merged and reverted PR was not resubmitted yet

Open
#495 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1.1k
Forks
2.2k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/apache/cordova-plugin-inappbrowser/pull/353 was accidentally merged, then reverted. A comment was left https://github.com/apache/cordova-plugin-inappbrowser/pull/353#issuecomment-469999442 but as far as I could figure out nothing happened, so these possibly good changes are left out of the codebase. We should look into this.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing pull request 353 and its linked comment to determine what was merged, reverted, and intended. Compare those changes with the current codebase; the work is done when the missing changes have been assessed and, if still appropriate, are resubmitted.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.