apache / apache/cordova-plugin-inappbrowser

iOS: Wrong position when toolbarposition=top

Open
#343 0 comments 7 reactions 0 assignees View on GitHub
platform: ios support
Dominant language
Java
Stars
1.1k
Forks
2.2k
PR merge metrics
No merged PRs in 30d

Description

Iphone X toolbar position is not correctly, both CDVWKInAppBrowser and CDVUIInAppBrowser got wrong position of toolbar when set toolbarposition=top
Does it normal?

![2018-11-05 4 43 04](https://user-images.githubusercontent.com/981381/47987241-fe333180-e119-11e8-88d3-fd2ab5a7b6a6.png)

![2018-11-05 4 44 39](https://user-images.githubusercontent.com/981381/47987346-3b97bf00-e11a-11e8-9528-0215368e7a55.png)

Contributor guide

Open the contributing guide

Research direction

Start by reading the toolbar positioning paths in CDVWKInAppBrowser and CDVUIInAppBrowser, then reproduce toolbarposition=top on an iPhone X using the screenshots as the reported behavior. Done means the toolbar is correctly positioned at the top in both implementations without breaking other toolbar positions.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, objective-c
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.